This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Drop realmReadOnly user info key #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
reviewed
Mar 15, 2018
| @@ -2,7 +2,7 @@ | |||
| {% if entity.attributes.size > 0 %} | |||
| enum Attributes: String { | |||
| {%- for attribute in entity.attributes -%} | |||
| {%- if attribute.realm_ignored or attribute.realm_read_only.size == 0 -%} | |||
| {%- if attribute.realm_ignored == false -%} | |||
There was a problem hiding this comment.
🤔 how come did it work before that == false?
There was a problem hiding this comment.
I don't know how it worked before I remove realmReadOnly, it was a bug. But with unit tests I saw that attribute.realm_ignored is not a valid statement. So I copy existing comparison and now it works with attribute.realm_ignored == false
AliSoftware
approved these changes
Mar 15, 2018
|
|
AliSoftware
force-pushed
the
feature/remove-realm-read-only
branch
from
07e6c44
to
cc40243
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for realmReadOnly user info key - fixes #28